Add support for 'zk.link' and some example linking commands #97
+84
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"zk.link" performs the file linking operation that `insertLinkAtLocation` does in "zk.new" but without creating a new note. This allows users to create new linking capabilities, such as using match to find related notes and creating a link from the found note.
Has both normal mode and visual mode behavior
Due to limitations of the neovim API
mickael-menu
approved these changes
Feb 6, 2023
| @@ -51,22 +51,45 @@ function M.get_lsp_location_from_selection() | |||
| } | |||
| end | |||
|
|
|||
| ---Fix to correct cursor location | |||
There was a problem hiding this comment.
The nvim cursor is (1,0)-indexed, so lines start at 1. Might be what's causing the issue you noticed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding support for zk-org/zk#284
"zk.link" performs the file linking operation that
insertLinkAtLocationdoes in "zk.new" but without creating a new note. This allows users to create new linking capabilities, such as using match to find related notes and creating a link from the found note.This PR also adds two commands:
ZkInsertLinkZkInsertLinkAtSelectionBoth use the note picker of choice to query all notes to find the desired note to create a link (solves #95)